Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native codes for Android #1745

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add native codes for Android #1745

merged 3 commits into from
Nov 27, 2024

Conversation

icyleaf
Copy link
Member

@icyleaf icyleaf commented Nov 27, 2024

This PR add native code shows both in teardown result page and app build detail page. it detect any native code is will render to the page, or leave it empty.

Screenshots

teardown result page

Teardown result page

app build detail page

It shows Universal if native codes include multi-arch.

App build detail page

Relates to #1735

Copy link

sentry-io bot commented Nov 27, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/services/teardown_service.rb

Function Unhandled Issue
process_android [**NoMethodError: undefined method native_codes' for an instance of AppInfo::AAB (NoMethodError)**](https://icyleaf.sentry.io/issues/6093476887/?referrer=github-open-pr-bot) ... <br> Event Count:` 1

Did you find this useful? React with a 👍 or 👎

@icyleaf icyleaf merged commit 4d47980 into develop Nov 27, 2024
2 checks passed
@rakuyoMo
Copy link
Contributor

rakuyoMo commented Nov 28, 2024

Have you considered including this content in the file name of the downloaded file?

Use the specific architecture name for a single architecture, and Universal for multiple architectures

@icyleaf icyleaf deleted the feat/native-codes-for-android branch November 28, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants