Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot detect Extract Method when multiple conditions are extracted to if else condition into a new method #265

Open
mkshiblu opened this issue Jul 15, 2022 · 1 comment
Labels

Comments

@mkshiblu
Copy link

Problem

Refactoring Miner was not able to detect that getData was extracted from dataAttr

Steps to Reproduce

  1. Go to mkshiblu/practice@d521357
  2. Run the chrome extension

Observed Behavior

  • No refactorings are reported by RefactoringMiner.

Java Diff

image

Note

  • The Above Java Example Test Code is a close recreation to this. Checkout it for some interesting comments from the developer.

  • Source code is compilable because of the addition of mock classes.

@tsantalis
Copy link
Owner

This is a rather rare scenario, which would take a lot of effort to implement.
Supporting the matching of conditional expressions with if statements is interesting though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants