Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEBT] Use "I" as a prefix for interface name #350

Closed
4 tasks
Romakita opened this issue May 5, 2018 · 3 comments
Closed
4 tasks

[DEBT] Use "I" as a prefix for interface name #350

Romakita opened this issue May 5, 2018 · 3 comments

Comments

@Romakita
Copy link
Collaborator

Romakita commented May 5, 2018

Informations

Type  Version
Debt 4.x -> 5.x

Description

Currently, all interfaces in Ts.ED doesn't follow the rule. Now the convention name for the Interface is to use the prefix "I".

To not break the legacy code, we can use that:

// new interface
export interface IName {
   ....
}
// legacy interface
/**
 * @deprecated Use IName insteadof
 */
export interface Name extends IName {}

Todos

  • Add "I" prefix on interface,
  • Deprecate the legacy interface,
  • Replace the legacy interface in the Ts.ED code by the new interface,
  • In the next major version, remove all deprecated interface.
@milewski
Copy link
Contributor

milewski commented May 5, 2018

wait... i thought the I was supposed to replace the need for Interface in the name... so if its to follow the I convention it should be IName instead of INameInterface

@Romakita
Copy link
Collaborator Author

Romakita commented May 5, 2018

Yes sorry ;) fixed

@Romakita Romakita added this to the SPRINT MAI milestone May 5, 2018
@Romakita Romakita modified the milestones: SPRINT MAI, BACKLOG Jul 3, 2018
@stale
Copy link

stale bot commented Oct 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 9, 2020
@stale stale bot closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants