Skip to content

Latest commit

 

History

History
23 lines (14 loc) · 787 Bytes

2021-11-02.md

File metadata and controls

23 lines (14 loc) · 787 Bytes

2 November 2021

or, …

  • GroupsSource extends PrivateS3Source with constructor(groupName) so that setSource("groups", req => req.params.groupName) works.

    Make it use a single bucket, nextstrain-groups, which stores objects under ${groupName}/ prefixes.

  • Add additional authz method to Source classes for write (create/update/delete), something like modifiableBy(user?).

    Or rename visibleTo(user?) and generalize to something like source.authz("read" | "write" | "manage", user)?

    Or maybe readableBy(user?), writableBy(user?), manageableBy(user?)?

  • For even public sources, urlFor(type, method?) and url(method?) need to produce signed URLs (or throw an error) for modifying methods (non-GET/HEAD).