Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows option to genealogical_nearest_neighbours #193

Open
jeromekelleher opened this issue May 28, 2019 · 3 comments
Open

Add windows option to genealogical_nearest_neighbours #193

jeromekelleher opened this issue May 28, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeromekelleher
Copy link
Member

#184 fixed a bug in the definition of the GNN statistic. Need to update the API to add an extra parameter treewise=False to allow this to be returned treewise.

@jeromekelleher jeromekelleher added this to the Python 0.1.6 milestone May 28, 2019
@jeromekelleher jeromekelleher self-assigned this May 28, 2019
@jeromekelleher
Copy link
Member Author

More generally, this should be defined in windows like other tree stats.

@jeromekelleher jeromekelleher changed the title Add treewise option to genealogical_nearest_neighbours Add windows option to genealogical_nearest_neighbours Aug 13, 2019
@jeromekelleher
Copy link
Member Author

We can push this back to 0.2.1 because after #313 is merged the default behaviour for windows=None is to strip the first dimension (which is what this is doing now). So, when updating we need to add an option windows=None which follows the same semantics as the other windowed tree stats.

@jeromekelleher jeromekelleher added the enhancement New feature or request label Sep 29, 2020
@jeromekelleher jeromekelleher removed this from the Python upcoming milestone Sep 29, 2020
@hyanwong
Copy link
Member

I think this may be rolled in to #683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants