Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group symbols & labels so they can be easily styled #241

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

hyanwong
Copy link
Member

This allows us to do e.g. in a jupyter notebook:

display(HTML('<style>svg #labels .mutations {display: none}</style>' + ts.draw_svg()))

to turn the mutation labels off. Similarly for symbols, etc etc.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #241 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   86.58%   86.58%   +<.01%     
==========================================
  Files          16       16              
  Lines        9389     9393       +4     
  Branches     1704     1704              
==========================================
+ Hits         8129     8133       +4     
  Misses        750      750              
  Partials      510      510
Flag Coverage Δ
#c_tests 86.58% <100%> (ø) ⬆️
#python_tests 98.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/drawing.py 94.9% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668a68...73b2347. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #241 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   86.58%   86.58%   +<.01%     
==========================================
  Files          16       16              
  Lines        9389     9393       +4     
  Branches     1704     1704              
==========================================
+ Hits         8129     8133       +4     
  Misses        750      750              
  Partials      510      510
Flag Coverage Δ
#c_tests 86.58% <100%> (ø) ⬆️
#python_tests 98.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/drawing.py 94.9% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668a68...73b2347. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #241 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   86.58%   86.58%   +<.01%     
==========================================
  Files          16       16              
  Lines        9389     9393       +4     
  Branches     1704     1704              
==========================================
+ Hits         8129     8133       +4     
  Misses        750      750              
  Partials      510      510
Flag Coverage Δ
#c_tests 86.58% <100%> (ø) ⬆️
#python_tests 98.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/drawing.py 94.9% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668a68...73b2347. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #241 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   86.58%   86.58%   +<.01%     
==========================================
  Files          16       16              
  Lines        9389     9393       +4     
  Branches     1704     1704              
==========================================
+ Hits         8129     8133       +4     
  Misses        750      750              
  Partials      510      510
Flag Coverage Δ
#c_tests 86.58% <100%> (ø) ⬆️
#python_tests 98.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/drawing.py 94.9% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668a68...73b2347. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #241 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   86.58%   86.58%   +<.01%     
==========================================
  Files          16       16              
  Lines        9389     9393       +4     
  Branches     1704     1704              
==========================================
+ Hits         8129     8133       +4     
  Misses        750      750              
  Partials      510      510
Flag Coverage Δ
#c_tests 86.58% <100%> (ø) ⬆️
#python_tests 98.21% <100%> (ø) ⬆️
Impacted Files Coverage Δ
python/tskit/drawing.py 94.9% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668a68...73b2347. Read the comment docs.

@jeromekelleher
Copy link
Member

LGTM, thanks!

@jeromekelleher jeromekelleher merged commit 57ff0ab into tskit-dev:master Jun 18, 2019
@hyanwong hyanwong deleted the group-svg-labels branch July 1, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants