Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xterm.js dependency to master #1113

Closed
maaslalani opened this issue May 15, 2023 · 3 comments
Closed

Bump xterm.js dependency to master #1113

maaslalani opened this issue May 15, 2023 · 3 comments
Labels

Comments

@maaslalani
Copy link

Hey there, first off, thank you for the awesome project.

Secondly, there has been a recent bug fix in the canvas renderer for xterm.js which is on the latest master but hasn't been released yet.

xtermjs/xterm.js#4120

Because ttyd is using the latest release (instead of @master) we are seeing the bug appear still in a project that depends on ttyd:

charmbracelet/vhs#249

I was hoping it would be possible for ttyd to bump the xterm.js dependency, if possible, to use the latest master code so that we can fix the canvas renderer issues we are seeing.

Thank you!

@tsl0922
Copy link
Owner

tsl0922 commented May 15, 2023

I've already bumped it to a recent 5.2.0-beta release (e01e213), does it work for you?

@maaslalani
Copy link
Author

Thanks so much! I will try it out. Really appreciate it ❤️

@maaslalani
Copy link
Author

Thank you, it worked! Very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants