Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot doesn't reconnect if remote server hangs up #35

Open
moggers87 opened this issue Feb 18, 2013 · 4 comments
Open

Bot doesn't reconnect if remote server hangs up #35

moggers87 opened this issue Feb 18, 2013 · 4 comments
Labels
Milestone

Comments

@moggers87
Copy link
Collaborator

I think adding the keepalive flag to the socket will sort this out, but I need to test this first.

@moggers87
Copy link
Collaborator Author

OK, SO_KEEPALIVE probably won't kill the socket early enough for us (2 hours versus 5 minutes)

I'm going to leave this until the new hook/event system is done, I can just reconnect if the server doesn't PING in x minutes or other

@moggers87
Copy link
Collaborator Author

This is done in theory, but things need rejigging quite a bit wrt core pluggin loading, so we'll wait for #49 first

@tsyesika
Copy link
Owner

tsyesika commented Mar 9, 2013

Also this could be a tricky one to test. We need to outline a test procedure in the ticket so we can test it and make sure it this is really done as this is our most serious bug we have open currently.

@moggers87
Copy link
Collaborator Author

I think the easiest way to simulate this is to kill the default route (as in route everything via localhost :P ) and wait for the bot to try and reconnect. If it does try, then we can close this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants