Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Megbot's multi-connection support #80

Open
moggers87 opened this issue Nov 3, 2017 · 0 comments
Open

Rework Megbot's multi-connection support #80

moggers87 opened this issue Nov 3, 2017 · 0 comments
Assignees

Comments

@moggers87
Copy link
Collaborator

Currently we have this horrible situation where each connection has its own thread, and each call to a plugin is spun off into a separate thread too.

This isn't too bad until you realise that each connection has its own copy of the plugin modules. In theory this was to allow module reloading, however it never worked and the syntax to fetch the local copy of a library is awful. Previously, certain libraries were added into the plugin's scope at load-time, but this made code readability even worse than it is now.

I propose that we make each connection its own process, allowing each connection to have its own copy of modules without resorting to any magic or unreadable syntax. If we wish to reintroduce code reloading at a later date, this will be significantly easier than before.

@moggers87 moggers87 self-assigned this Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant