Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is calling plugins? #83

Open
moggers87 opened this issue Apr 14, 2018 · 1 comment
Open

What is calling plugins? #83

moggers87 opened this issue Apr 14, 2018 · 1 comment

Comments

@moggers87
Copy link
Collaborator

This core plugin has at least 3 ways it can call event handlers from plugins:

  • connection.hooker.hook(connection, info) which is labelled as "old system"
  • connection.handler.event(event) which is labelled as "new events/hook system"
  • connection.core["Coreexecutor"].main(connection, info, info.plugin_name) which is labelled as new or old
    • but plugins are run in threads and it appears to be the only place where that is so

This mess needs to be cleaned up and we should use one system for everything.

@moggers87
Copy link
Collaborator Author

@xray7224 choose one and I can convert everything to use that ☺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant