Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPump.request() should be able to get any type of content #132

Open
kabniel opened this issue Jun 16, 2015 · 0 comments
Open

PyPump.request() should be able to get any type of content #132

kabniel opened this issue Jun 16, 2015 · 0 comments

Comments

@kabniel
Copy link
Collaborator

kabniel commented Jun 16, 2015

Current version of PyPump.request() returns response.json(), which means it can only be used for requests where the server will return json data.

We should rewrite it so that it can return all types of content (the full response object?), and let the caller of PyPump.request() decide what to do with it.

This would f.ex let us download media files from https://example.com/uploads/ with pump.request(imgobject.original.url) instead of having to do something weird like requests.get(imgobject.original.url, auth=pump.setup_oauth_client())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant