You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current version of PyPump.request() returns response.json(), which means it can only be used for requests where the server will return json data.
We should rewrite it so that it can return all types of content (the full response object?), and let the caller of PyPump.request() decide what to do with it.
This would f.ex let us download media files from https://example.com/uploads/ with pump.request(imgobject.original.url) instead of having to do something weird like requests.get(imgobject.original.url, auth=pump.setup_oauth_client())
The text was updated successfully, but these errors were encountered:
Current version of
PyPump.request()
returnsresponse.json()
, which means it can only be used for requests where the server will return json data.We should rewrite it so that it can return all types of content (the full response object?), and let the caller of
PyPump.request()
decide what to do with it.This would f.ex let us download media files from
https://example.com/uploads/
withpump.request(imgobject.original.url
) instead of having to do something weird likerequests.get(imgobject.original.url, auth=pump.setup_oauth_client())
The text was updated successfully, but these errors were encountered: