Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract ESLint and TS config to an external package #242

Merged
merged 7 commits into from
Nov 28, 2021

Conversation

tsyirvo
Copy link
Owner

@tsyirvo tsyirvo commented Nov 28, 2021

Extract the ESLint and TS config to an external package (eslint-config-tsyirvo-react-native).

Also, remove some root files and put the configuration in the package.json.

@tsyirvobot
Copy link

tsyirvobot commented Nov 28, 2021

Fails
🚫

Danger failed to run dangerfile.ts.

Error TypeError

(0 , includes_1.default) is not a function
TypeError: (0 , includes_1.default) is not a function
    at dangerfile.ts:79:81
    at Array.some (<anonymous>)
    at Object.<anonymous> (dangerfile.ts:79:31)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.requireFromString [as default] (/home/runner/work/react-native-starter/react-native-starter/node_modules/require-from-string/index.js:28:4)
    at /home/runner/work/react-native-starter/react-native-starter/node_modules/danger/distribution/runner/runners/inline.js:157:63
    at step (/home/runner/work/react-native-starter/react-native-starter/node_modules/danger/distribution/runner/runners/inline.js:52:23)
    at Object.next (/home/runner/work/react-native-starter/react-native-starter/node_modules/danger/distribution/runner/runners/inline.js:33:53)
    at /home/runner/work/react-native-starter/react-native-starter/node_modules/danger/distribution/runner/runners/inline.js:27:71
    at new Promise (<anonymous>)

Dangerfile

74| 
75| // Using schedule because this is an async task
76| schedule(
77|   todos({
78|     ignore: ['CHANGELOG.md', /tests/, /stories/],
-----------------------------------------------------------------------------------^
79|     keywords: ['TODO', 'FIXME', 'TO-DO', 'TO-FIX'],
80|   }),
81| );
82| 

Generated by 🚫 dangerJS against 1143310

@tsyirvo tsyirvo force-pushed the gab/feat/extract-eslint-config branch from aad9b6d to 1143310 Compare November 28, 2021 15:56
@tsyirvo tsyirvo force-pushed the gab/feat/extract-eslint-config branch from 1143310 to 9d899ad Compare November 28, 2021 16:18
@tsyirvo tsyirvo merged commit 8052eb8 into develop Nov 28, 2021
@tsyirvo tsyirvo deleted the gab/feat/extract-eslint-config branch November 28, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants