Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4.1-beta breaks downstream #740

Open
rusq opened this issue Sep 10, 2024 · 4 comments
Open

v3.4.1-beta breaks downstream #740

rusq opened this issue Sep 10, 2024 · 4 comments
Milestone

Comments

@rusq
Copy link

rusq commented Sep 10, 2024

Version: v3.4.1-beta

Context.Bot() used to return *telebot.Bot, but now returns telebot.API interface. I used to call "Handle" on what was returned by Context.Bot(), but the latest change breaks it.

Could the backward compatibility promise honoured in v3 please, and could breaking changes be introduced only with the major version number increase, as per Module Version Numbering?

@rusq rusq changed the title Latest master breaks downstream v3.4.1-beta breaks downstream Sep 10, 2024
@demget
Copy link
Collaborator

demget commented Sep 23, 2024

Fair point. What were the methods you used in Bot structure returned from context?

@demget
Copy link
Collaborator

demget commented Sep 23, 2024

Please ignore v3.4 versions, but take into account that the V3 major version won't be developing anymore. So to enable new Bot API versions you'll have to migrate anyway. Unless someone will make a PR for the new minor version of V3, then I'll keep it updated as long as possible.

@demget demget added this to the V4.0 milestone Sep 23, 2024
@demget
Copy link
Collaborator

demget commented Sep 23, 2024

Btw you shouldn't use Handle for dynamic handling, that's basically not right.

@rusq
Copy link
Author

rusq commented Sep 24, 2024

Hey @demget, thanks for the response. Apart from dynamic handling, I was using

voice.Send(c.Bot(), chat, opts)

where "c" is telebot.Context, and "voice" is telebot.Voice.

When you say "migrate anyway", do you mean that telebot library won't be developed anymore? Noticed that there's a V4 milestone, amazing!

I was using v3.3.x, but needed the Star payments, so I decided to try my luck with v.3.4.1-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants