Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot doesn't crash when starting multiple instances #752

Open
zewebdev1337 opened this issue Oct 23, 2024 · 1 comment
Open

Bot doesn't crash when starting multiple instances #752

zewebdev1337 opened this issue Oct 23, 2024 · 1 comment

Comments

@zewebdev1337
Copy link

zewebdev1337 commented Oct 23, 2024

I've noticed that you can start multiple instances and they both will keep running and polling, which of course leads to undesired behavior.

Checking the issues I found #494, where the user states that the bot does indeed crash if more than one instance is started. I eyeballed around the repo quickly and see some code to return errors from the parsed json response in botraw.Start. However, I tried starting normally, inside a goroutine and inside a waitgroup since bot.Start() is blocking, but none of what I've tried succeeds in triggering the crash.

Edit: I'm running V3, I'm going to look into migrating to V4 and see if the issue exists there, however I have a large library of bots in V3 (and some in V2 that I just recently migrated to V3.).

I understand maintainer focus is on V4, that's completely fair, I'll see how does migrating to V4 go and based on how that goes, if I see fit and have the time I'll try to implement/fix this on V3.

@zewebdev1337
Copy link
Author

after a quick check, this bug seems to also be present in V4
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant