-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(widget): add patch_style
to Spans
#148
Conversation
I'm not sure how all the checks failed because it's literally a drop-in method that does not remove or change anything public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think patch_style
could be helpful to widget authors. I think I'd like to see a similar Span.patch_style()
also.
Sorry, just a typo. The method is called |
I know - the current PR only changes |
Reply to myself: Span has a public |
Fixed the reset/default conflict in `Spans.reset_style()`.
Do you guys want |
… general Spans.patch_style().
Fixed the reset/default conflict in `Spans.reset_style()`.
I tried to make the commit messages follow convention but it duplicated the commits :/ |
patch_style
to Spans
patch_style
to Spans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, can you squash this into a single commit with a conventional commit like feat(widget): add style methods to Span and Spans
(or something similar). Looks like an easy merge once that's done.
@joshka The requested changes have been made 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
Added a method to
Spans
that patches the style of eachSpan
in theSpans
similarly toText.patch_style()
.