-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix scrollbar ascii illustrations and calendar doc paths #272
Conversation
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 36 36
Lines 7301 7301
=======================================
Hits 6024 6024
Misses 1277 1277
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch ! Thanks for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! Is it possible to have a doc preview on each PR?
I'm not aware of any way to do that. Personally, I just use |
Didn't know about |
…t block 'cargo doc' and 'rust-analyzer' removes many whitespaces thus making those parts render improperly
Head branch was pushed to by a user without write access
ca454a3
to
27e59aa
Compare
Sorry, I had to sign the commits for this to be merged. It would be nice to include that information in the |
This PR fixes scrollbar's documentation, which tried to showcase its elements. This requires for the text to be rendered exactly how it was written, which isn't the case for the cargo and other tools. Thus, it requires to be wrapped inside text blocks, which preserves text as is.
Secondly, there were problems with doc paths in calendar's documentation.
Finally, recently merged changes in
block.rs
were not formatted properly