Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible duplicated flag -march for llvm_etiss_pulpin.cmake #8

Open
zhouxinyu0723 opened this issue Feb 24, 2023 · 2 comments
Open
Assignees

Comments

@PhilippvK
Copy link
Collaborator

Good catch!

If you compile using make VERBOSE=1 you will see that there are in fact much worse duplications happening somewhere else. For example --gcc-toolchain is used 4 times on the command below:

/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/llvm/bin/clang-14  --target=riscv32 --gcc-toolchain=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc --sysroot=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc/riscv32-unknown-elf -msmall-data-limit=8 -mno-save-restore -fsigned-char -ffunction-sections -fdata-sections -Wall -Wextra -Wshadow -Wformat=2 -Wundef -Wsign-conversion -Wno-unused-parameter --target=riscv32 --gcc-toolchain=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc --sysroot=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc/riscv32-unknown-elf -DSTDIO_FAKE=2 -DSTDIO_UART=1 -DSTDIO_NULL=0 -DCONFIG_STDIO=2   -O3 -DNDEBUG     -O3     -ffunction-sections     -fdata-sections   -DportasmHANDLE_INTERRUPT=vSystemIrqHandler --target=riscv32 --gcc-toolchain=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc --sysroot=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc/riscv32-unknown-elf -msmall-data-limit=8 -mno-save-restore -fsigned-char -ffunction-sections -fdata-sections -Wall -Wextra -Wshadow -Wformat=2 -Wundef -Wsign-conversion -Wno-unused-parameter -nostartfiles -Wl,--gc-sections -Wl,-Map,memory.map -nostartfiles             -T /var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/src/mlif/cmake/targets/gvsoc/target/pulpissimo/link.ld               -DportasmHANDLE_INTERRUPT=vSystemIrqHandler --target=riscv32 --gcc-toolchain=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc --sysroot=/var/tmp/ga87puy/students/xinyou/mlonmcu/workspace/deps/install/pulp_gcc/riscv32-unknown-elf -msmall-data-limit=8 -mno-save-restore -fsigned-char -ffunction-sections -fdata-sections -Wall -Wextra -Wshadow -Wformat=2 -Wundef -Wsign-conversion -Wno-unused-parameter -nostartfiles -Wl,--gc-sections -Wl,-Map,memory.map     -Xlinker --gc-sections     -Xlinker -Map=linker.map     -Xlinker --cref  CMakeFiles/generic_mlif.dir/main.c.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/target/pulpissimo/system_metal.c.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/target/pulpissimo/crt0.S.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/target/pulpissimo/vectors_metal.S.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/libc/malloc/malloc_internal.c.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/libc/malloc/cl_l1_malloc.c.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/libc/syscalls.c.obj CMakeFiles/generic_mlif.dir/__/cmake/targets/gvsoc/libc/pulp_malloc.c.obj -o ../bin/generic_mlif  ../lib/libtarget_sw_lib.a ../lib/ml_interface/libml_interface.a ../lib/ml_interface/default_model_support/libmodel_support.a ../lib/ml_interface/libml_interface_base.a ../lib/support/libsupport.a ../lib/ml_interface/libtvm_extension.a ../libtvm_aot_rt.a ../lib/ml_interface/libtvm_extension.a ../libtvm_aot_rt.a -lm 

@PhilippvK
Copy link
Collaborator

Reopening until fixed for every supported RISCV target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants