-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of CMake versions #59
Comments
@fabianpedd do we really have to use such a recent cmake version? it would be nice to stick with 3.16 which is available in ubuntu 20 |
@rafzi I think I was using some recent feature only available in newer CMake versions. I will have a look and check if it's actually necessary. But the unit tests run just fine on the GH action machines (both on Ubuntu 18 and 20). Do they have newer CMake versions on their machines? |
I think there was some strange behavior where i can double check with the version of cmake installed on the chair computers by default and report if the issue still exists. |
Unrelated to muriscvnn: Managing the cmake version used by MLonMCU would still be a good idea as some of the main design aspects of the project have been:
However there are also some disadvantages:
In the end we could go with a hybrid approach as also possible with all the other dependencies (riscv_gcc, tflmc,…)
|
See #97 |
The new muriscvnn has a relatively strict requirement on the used CMake version (3.22 or so) which leads to erros on most OSes.
Currently this results in an error during
mlonmcu setup
which is quite hard to read so we should catch stuff like this earlier.Two ideas:
utils.cmake()
is called instead of the system one._validate_muriscvnn()
function which throws an more-readable error if the version of CMake installed on the system is too low.@rafzi @fabianpedd what do you think?
The text was updated successfully, but these errors were encountered: