TMDiskCache trash directory creation on the calling thread #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the trash directory creation happening asynchronously leads to a race condition and potential crash on slower hardware.
One of my test cases run against iPhone 4 failed consistently in TMDiskCache.m line 205 with Cocoa error 4 because the temp directory was not yet created when consumed for the first time.
This is one time, quick operation and the temp directory has to be readily available when sharedTrashURL returns control on the calling thread?