-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider supporting iOS 7 #51
Comments
I added basic iOS 7 compatibility in a547d68. There may well still be some other code lying around that could use iOS 8-only APIs, but this was all that was needed to get the NSExtensionItem demo working on iOS 7 for me. |
Great, thanks. Do you think this is something we should do? I have mixed feelings. On one hand, it’d be easy enough and might help adoption. On the other hand, I'm not even sure how useful it is (in the Tumblr case, we have a code to create different Facebook/Twitter strings that include the URLs on iOS 7 where we can’t provide multiple attachments, so we probably wouldn't even use this ourselves). Not to mention I don’t really want to encourage supporting iOS 7. |
The more I think of it, the more I think we should do it. Not necessarily promote it anywhere, but just in order to make it easier to include this pod as a dependency of iOS 7+ projects. |
This is more work than I let on since it’d require redoing the Xcode project to work as a static library and not a framework 😕 Leaning towards “not for 1.0” as a result. |
A few thoughts:
|
I agree with all of this just don’t have any time to work on it before heading off on vacation. I'll let it up to @mattbischoff to decide if we either hold 1.0.0 until one of us has time to rearrange things, or if we prioritize this for a subsequent point release. |
It would just pass a single item through rather than providing any of the benefits, but at least would make it easier for apps that still support iOS 7 to simply drop XExtensionItem in.
The text was updated successfully, but these errors were encountered: