Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tumblr/tumblr.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.0
Choose a base ref
...
head repository: tumblr/tumblr.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.1
Choose a head ref
  • 7 commits
  • 5 files changed
  • 4 contributors

Commits on Oct 30, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d776378 View commit details

Commits on Sep 30, 2021

  1. Add Typescript signature for TumblrClient.getRequest

    This hit me when I was writing an internal tool in typescript and wanted to access a custom endpoint.
    gravityrail authored Sep 30, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2915f7c View commit details

Commits on Dec 18, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    977bd55 View commit details

Commits on Dec 19, 2021

  1. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    sanmai Alexey Kopytko
    Copy the full SHA
    946db5e View commit details

Commits on Dec 20, 2021

  1. Merge pull request #106 from gravityrail/patch-1

    Add Typescript signature for TumblrClient.getRequest
    cyle authored Dec 20, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9ba3891 View commit details

Commits on Dec 21, 2021

  1. Merge pull request #107 from sanmai/pr/2021-12/ci-start

    Add YAML validation to bootstrap GitHub workflows
    cyle authored Dec 21, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    214cc18 View commit details

Commits on Dec 24, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    fea5926 View commit details
Showing with 79 additions and 20 deletions.
  1. +56 −0 .github/workflows/ci.yaml
  2. +20 −0 .github/workflows/validate_yaml.yaml
  3. +0 −8 .travis.yml
  4. +0 −12 CONTRIBUTING.md
  5. +3 −0 lib/tumblr.d.ts
56 changes: 56 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
# yamllint disable rule:line-length
# yamllint disable rule:braces
name: CI

on:
pull_request:
push:
branches:
- main
- master

jobs:
tests:
name: Testing with Node.js ${{ matrix.node-version }}
runs-on: ubuntu-latest

strategy:
matrix:
node-version:
- '6.x'
- '8.x'
- '10.x'
- '12.x'
- '14.x'
- '15.x'
- '16.x'
- '17.x'

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Cache dependencies
uses: actions/cache@v2
with:
path: ~/.npm
key: npm-${{ matrix.node-version }}-${{ hashFiles('package*.json') }}
restore-keys: |
npm-${{ matrix.node-version }}-
- name: Install dependencies
run: |
npm install --ignore-scripts
- name: Build
run: |
npm run build --if-present
- name: Run tests
run: |
npm test
20 changes: 20 additions & 0 deletions .github/workflows/validate_yaml.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# yamllint disable rule:line-length

name: YAML Validation

on:
pull_request:
push:

jobs:
validate-yaml:
name: Validate YAML
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Run YAML linter
run: |
find . -path \*/vendor -prune -false -o -name \*.y*ml | xargs yamllint -d relaxed
8 changes: 0 additions & 8 deletions .travis.yml

This file was deleted.

12 changes: 0 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -8,19 +8,7 @@ We want to make contributing to `tumblr.js` as easy and transparent as possible.
2. If you've added code that should be tested, add tests.
3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes.
5. If you haven't already, complete the Contributor License Agreement ("CLA").

## Contributor License Agreement ("CLA")

In order to accept your contribution, we need you to submit a CLA. If you open
a pull request, a bot will automatically check if you have already submitted
one. If not it will ask you to do so by visiting a link and signing in with
GitHub.

The CLA, contact information, and GitHub sign-in can be found here:
[https://yahoocla.herokuapp.com](https://yahoocla.herokuapp.com).

## License

By contributing to tumblr.js you agree that your contributions will be licensed under its Apache 2.0 license.

3 changes: 3 additions & 0 deletions lib/tumblr.d.ts
Original file line number Diff line number Diff line change
@@ -72,6 +72,9 @@ declare module 'tumblr.js' {

unlikePost(params: object, callback: TumblrClientCallback): void
unlikePost(id: number | string, reblogKey: string, callback: TumblrClientCallback): void

getRequest(apiPath: string, paramsOrCallback?: object | null | TumblrClientCallback, callback?: TumblrClientCallback): Request
postRequest(apiPath: string, paramsOrCallback?: object | null | TumblrClientCallback, callback?: TumblrClientCallback): Request
}

function createClient(options: any): TumblrClient;