Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing cidr_util with ipnet #41

Closed
M0dEx opened this issue Feb 5, 2024 · 0 comments · Fixed by #42
Closed

Replacing cidr_util with ipnet #41

M0dEx opened this issue Feb 5, 2024 · 0 comments · Fixed by #42
Assignees
@xmh0511
Labels
good first issue Good for newcomers

Comments

@M0dEx
Copy link

M0dEx commented Feb 5, 2024

In #40, a dependency to cidr_util was added. From what I understand, it's a one-time use crate just for tun2.

Could we not replace this with something such as ipnet, which:

  • is relatively popular (hence more likely to be used by dependents of tun2)
  • provides the required features
  • could also be useful later on with the integration of IPv6
    ?
@xmh0511 xmh0511 added the good first issue Good for newcomers label Feb 6, 2024
@xmh0511 xmh0511 self-assigned this Feb 6, 2024
@xmh0511 xmh0511 linked a pull request Feb 6, 2024 that will close this issue
migrate to ipnet #42
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmh0511 xmh0511

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate to ipnet
2 participants
@xmh0511 @M0dEx