Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context.registration to statements #4

Open
garemoko opened this issue Oct 22, 2015 · 10 comments
Open

Add context.registration to statements #4

garemoko opened this issue Oct 22, 2015 · 10 comments

Comments

@garemoko
Copy link
Contributor

We should add a context.registration to statements that represents a particular refresh of/visit to the page the H5P sits on.

This could be achieved by generating the UUID here using code like this and appending it to statements here.

This would help to enable the LRS to distinguish between attempts at the content. See the discussion here.

@limikael
Copy link
Contributor

Hm... Should the "registration session" be the page visit, or should it be the php login session?

In general, I think out policy for this plugin is that we can add as much information as we want. If there is something that is "controversial", then we can add that also, but with an option to turn it on and off or change behavior under an "advanced settings" tab in the settings.

In this case, are there clear reasons why it should be the page visit and not the php session you think? Or should there be a way to change it?

Apart from that, sounds like a good plan! Go ahead and send a pull request if you want!

@limikael
Copy link
Contributor

limikael commented Dec 6, 2015

Ping? :) I'm considering closing this issue, just because open issues are an eyesore to me. @garemoko have you given this any thought? If not, we can close it for now, and then we can always re-open it later.

@garemoko
Copy link
Contributor Author

garemoko commented Dec 7, 2015

Hi. I'll try and take a look at this and respond tomorrow. Sorry for the delay!

@limikael
Copy link
Contributor

limikael commented Dec 8, 2015

Cool!

@garemoko
Copy link
Contributor Author

garemoko commented Dec 8, 2015

Hi, sorry again for the delay.

The registration should be page visit because the H5P content resets every time you refresh the page. If progress was bookmarked, then PHP session would make more sense.

@limikael
Copy link
Contributor

limikael commented Dec 8, 2015

Makes sense

@limikael
Copy link
Contributor

limikael commented Mar 1, 2016

Hi @garemoko

Open source hacking = good karma, you know... :)

@garemoko
Copy link
Contributor Author

garemoko commented Mar 1, 2016

@limikael ha! I won't discount that I might do this at some point, but lots of other priorities at the moment I'm afraid (some of them open source!)

@limikael
Copy link
Contributor

limikael commented Mar 1, 2016

:) Do you have a particular use case or user story or such where this would be useful? If so, then maybe it will motivate me to actually getting around to implementing it...

@garemoko
Copy link
Contributor Author

garemoko commented Mar 1, 2016

It would allow you to report on all activity on a single visit to a page e.g. an attempt at a quiz made up of questions on a page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants