Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code should be golint-clean #12

Closed
cgrigis opened this issue Oct 7, 2019 · 1 comment
Closed

code should be golint-clean #12

cgrigis opened this issue Oct 7, 2019 · 1 comment

Comments

@cgrigis
Copy link
Contributor

cgrigis commented Oct 7, 2019

Hello,

Running golint ./... at the root directory lists a few issues (minor things such as underscore in names, += 1 --> ++, missing comments).
For code quality purposes, I would suggest to fix these, as well as adding a lint step in the CI chain to ensure it remains clean.

Thank you!
@ChristianMct
Copy link
Collaborator

One of our next focus is to improve our testing/benchmarking/CI pipeline. So this suggestion comes right on time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristianMct @cgrigis