Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add shell check workflow for shell folder #32

Closed
tungbq opened this issue Jun 4, 2023 · 5 comments · Fixed by #212
Closed

[ci] Add shell check workflow for shell folder #32

tungbq opened this issue Jun 4, 2023 · 5 comments · Fixed by #212
Assignees
Labels
ci good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tungbq
Copy link
Owner

tungbq commented Jun 4, 2023

It's good if we could develop a workflow for checking shell script under shell folder https://github.com/tungbq/devops-basic/tree/main/shell
It could be run on every PRs that needs to merge onto main branch and contains change in the shell folder

Reference: We could investigate this checker https://github.com/marketplace/actions/shellcheck

@tungbq tungbq added help wanted Extra attention is needed good first issue Good for newcomers ci labels Jun 4, 2023
@gaus07
Copy link
Contributor

gaus07 commented Aug 27, 2023

/assign

@tungbq
Copy link
Owner Author

tungbq commented Aug 27, 2023

Thanks @gaus07 for your willing to help on this issue! Currently we dont have the auto assign feature on this repo, so I assigned it to you manually.

@gaus07
Copy link
Contributor

gaus07 commented Aug 28, 2023

@tungbq I have created a PR in which I made a workflow which will show all the errors and warnings of .sh files. is that it or I have to do something more ?

@tungbq
Copy link
Owner Author

tungbq commented Aug 28, 2023

Thanks @gaus07 for your contribution. It's a very good work, appreciated it!

@tungbq
Copy link
Owner Author

tungbq commented Aug 28, 2023

@gaus07 the next step would be fixing all the error on the shell check results. This will be covered in other separated tasks.
Since there has a lot of errors, I think it's better if we device them by component
image
For example git, k8s,... each of component should have separated issues to track and fix.

We need contribution on this as well. So, feel free to open the issue to fix this if you are willing to, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants