Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider readonly properties in interfaces (replacing getXxx()) #8

Open
sharwell opened this issue Oct 3, 2016 · 2 comments
Open

Consider readonly properties in interfaces (replacing getXxx()) #8

sharwell opened this issue Oct 3, 2016 · 2 comments
Assignees
@BurtHarris
Labels
ts-flavor
Milestone
Beta 0.5

Comments

@sharwell
Copy link
Member

sharwell commented Oct 3, 2016

Currently the Tree interface contains the following method (#5):

getParent(): Tree;

We should consider using the following form, where a property is exposed instead of a method:

readonly parent: Tree;
@sharwell sharwell mentioned this issue Oct 3, 2016
Merged
@BurtHarris
Copy link
Collaborator

Yes, this sounds good. P.S. readonly is brand new in TypeScript 2.0.

@sharwell sharwell self-assigned this Jan 5, 2017
@sharwell sharwell mentioned this issue Jan 5, 2017
Merged
@sharwell sharwell added this to the 0.4.0-alpha.3 milestone Jan 6, 2017
@BurtHarris
Copy link
Collaborator

Reopening because so many 'getXxx()' or functional equivalent remain.

@BurtHarris BurtHarris reopened this May 21, 2017
@BurtHarris BurtHarris mentioned this issue May 21, 2017
Open
@BurtHarris BurtHarris changed the title Consider readonly properties in interfaces Consider readonly properties in interfaces (replacing getXxx()) May 21, 2017
@BurtHarris BurtHarris assigned BurtHarris and unassigned sharwell Jun 11, 2017
@BurtHarris BurtHarris removed the fixed label Jun 11, 2017
@BurtHarris BurtHarris modified the milestones: Beta 0.5, 0.4.0-alpha.3 Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BurtHarris BurtHarris

Labels
ts-flavor
Projects
None yet
Milestone
Beta 0.5
Development

No branches or pull requests
2 participants
@sharwell @BurtHarris