Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ImmutableSet method naming #47

Open
sharwell opened this issue Mar 16, 2017 · 0 comments
Open

Review ImmutableSet method naming #47

sharwell opened this issue Mar 16, 2017 · 0 comments

Comments

@sharwell
Copy link
Member

The map from IImmutableSet<T> to ImmutableSet<T> does not completely align with the Set<T> interface. While some of the names could be updated in the Java code to immediately match the Set<T> conventions, there are many methods which have no direct mapping. It's not currently clear to me how these should all map.

IImmutableSet<T> ImmutableSet<T> Set<T>
Intersect intersect retainAll
Except except removeAll
SymmetricExcept symmetricExcept n/a
Union union addAll
SetEquals setEquals equals
IsProperSubsetOf isProperSubsetOf n/a
IsProperSupersetOf isProperSupersetOf n/a
IsSubsetOf isSubsetOf n/a
IsSupersetOf isSupersetOf containsAll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant