Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetAllConnectionConfigs does not handle failure well #458

Closed
kaidaguerre opened this issue Nov 28, 2022 · 0 comments · Fixed by #459
Closed

SetAllConnectionConfigs does not handle failure well #458

kaidaguerre opened this issue Nov 28, 2022 · 0 comments · Fixed by #459

Comments

@kaidaguerre
Copy link
Contributor

If any connecitons fail the whole operation fails.

Instead, return a list of failed connections
@kaidaguerre kaidaguerre changed the title SetAllCOnnectionConfigs does not handle failure well SetAllConnectionConfigs does not handle failure well Nov 28, 2022
@kaidaguerre kaidaguerre linked a pull request Nov 29, 2022 that will close this issue
Update SetAllConnectionConfigs to return map of failed connections. Closes #458 #459
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kaidaguerre