-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New .NET 4.5 project supporting Owin.Host.SystemWeb #241
Conversation
And sorry for having to create it in VS2013. I don't have 2012 at the moment... |
Looks good, thanks. Would you be able to write a small section in the README with respect to OWIN support in i18n as it stands after this addition? |
I've added a stub OWIN section to the readme. |
will do. |
Pull request created. |
I've merged the pull request. WRT the NuGet package, I would rather be careful about being associated with binaries compiled by others. Would you mind removing myself and Daniel from the metadata of your package. Alternatively delete it and I'll re-create one from this end. Thanks. |
Deleted. You can create a new one. |
Hmmm, NuGet doesn't seem to allow package re-creation:
Any ideas for a new name for i18n.Owin.SystemWeb? |
Hmmm... I18N.WebApi? I18N.Owin.Katana? |
@turquoiseowl I added you to the package owner. You can confirm the ownership and re-publish your compiled package. You can also remove me from owners. |
I've settled with i18n.Adapter.OwinSystemWeb, reason being that arguably i18n.Owin.... should be reserved for a pure OWIN version of i18n - see #243. Let me know if you have problems. Thanks. |
I created a new .NET 4.5 project i18n.Owin.SystemWeb to support Owin hosted in IIS.
The project is still dependent on System.Web so it is not "pure" Owin but more like an intermediate version for Katana only.
"Pure" Owin support will require restructure the code base. We will probably need to separate the code to more packages (i18n.core, i18n.owin, i18n.systemweb, i18n.owin.systemweb) so I'm leaving the decision to other folks.
The existing i18n project is not changed except for incorporating fix by suddenelfilio https://github.com/suddenelfilio/i18n/commit/ca753201ad294552163f4b3320b1dba25234e4b9
If you use it in ASP.NET, all the existing configuration/setup still works. If you use it in Owin hosted in IIS, you can configure middleware by code (no web.config change in this case).