Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Windows builds using wrong compiler in Actions #10

Open
FredMK opened this issue Dec 6, 2024 · 1 comment
Open

[Bug]: Windows builds using wrong compiler in Actions #10

FredMK opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@FredMK
Copy link

FredMK commented Dec 6, 2024

Description

The Github Actions builds are using incorrect configurations for the Windows builds.
For PHP the required compiler version is changing based on the PHP version, for example 8.3 uses Visual Studio 2019 (VS16), 8.4 uses Visual Studio 2022 (VS17).
The problem, that the Actions is always using the latest version which is currently Visual Studio 2022 (VS17).
If you compile with the wrong version, the extension is useless because you cannot load it, you got the error like this one: "Warning: PHP Startup: Can't load module '...\php\ext\libsql_php.dll' as it's linked with 14.41, but the core is linked with 14.29 in Unknown on line 0"
Basically the Visual C++ version in the extension is higher than it is in PHP, but you cannot compile that specific PHP version with a higher version.

Could you please correct the it always uses the required compiler, or at least add the 8.4 which currently using Visual Studio 2022?
You can make 8.3 work as well, you just need to change the runner version to Windows2019, because it's using Visual Studio 2019.

Thank you!

Minimal Reproduction

Try to load the compiled Windows 8.3 extension for PHP 8.3.

Exception or Error

Warning: PHP Startup: Can't load module '...\php\ext\libsql_php.dll' as it's linked with 14.41, but the core is linked with 14.29 in Unknown on line 0
PHP 8.3.14 (cli) (built: Nov 19 2024 15:53:36) (NTS Visual C++ 2019 x64)

@FredMK FredMK added the bug Something isn't working label Dec 6, 2024
@darkterminal
Copy link
Collaborator

darkterminal commented Dec 25, 2024

I will release a new version after I finish the turso-php-installer that also compatible with new build version. Thank for your report @FredMK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants