Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-bot-sdk uses an unspecced original_event field from the /relations response #263

Closed
clokep opened this issue Oct 3, 2022 · 2 comments · Fixed by #264
Closed

matrix-bot-sdk uses an unspecced original_event field from the /relations response #263

clokep opened this issue Oct 3, 2022 · 2 comments · Fixed by #264
Labels
bug Something isn't working

Comments

@clokep
Copy link

clokep commented Oct 3, 2022

The /relations endpoint does not return an original_event field, yet the matrix-bot-sdk uses it.

We would like to remove support for this from Synapse in < 6 months. See matrix-org/synapse#12930 for more context.
@clokep clokep added the bug Something isn't working label Oct 3, 2022
@clokep
Copy link
Author

clokep commented Oct 3, 2022

This seems to mostly just be piping back information from the raw request, so maybe this just needs some documentation updates?

@clokep clokep mentioned this issue Oct 3, 2022
Open
@turt2live turt2live mentioned this issue Oct 4, 2022
Merged
@turt2live
Copy link
Owner

thanks for reporting this <3

@clokep clokep changed the title matrix-js-sdk uses an unspecced original_event field from the /relations response matrix-bot-sdk uses an unspecced original_event field from the /relations response Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix & make GET /relations stable turt2live/matrix-bot-sdk
2 participants
@clokep @turt2live