-
Notifications
You must be signed in to change notification settings - Fork 45
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a requests session to Uploader [Feature Request] #77
Comments
Maybe it is not clear from the initial comment, but I would be willing to spend time myself implementing the feature, if you think it would be a good idea. |
Sounds good! It will be great if you could open a PR for this! |
It would be handy if there was a way to provide a custom HTTP stack, like in tus-js-client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would make the library more flexible if the Uploader could be given a requests Session object which it uses to make all requests.
Custom requests sessions can be used for many things. For example, I use them myself to capture all 401 Unauthorized errors when my tokens are expired, make sure I'm re-authenticated and repeat the request. I've seen others use them to fix a URL base or adding custom headers.
Would
tus-py-client
maintainers be open to providing the ability to initialize anUploader
with a customrequests.Session
object to enable use cases like this?The text was updated successfully, but these errors were encountered: