Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow requests without Content-Length #135

Closed
ronag opened this issue Oct 16, 2018 · 3 comments
Closed

Allow requests without Content-Length #135

ronag opened this issue Oct 16, 2018 · 3 comments

Comments

@ronag
Copy link
Contributor

ronag commented Oct 16, 2018 •
edited
Loading

Seems unnecessarily strict to me even as a SHOULD. Right now clients working with growing resources would have to wait a batch up a block of data before sending it. Would be nice to support streaming.

What is the rationale of the following?

If a PATCH request does not include a Content-Length header containing an integer value larger than 0, the server SHOULD return a 400 Bad Request status.
@Acconut
Copy link
Member

Acconut commented Oct 16, 2018 •
edited
Loading

You added this statement to the protocol in #131 (see https://github.com/tus/tus-resumable-upload-protocol/pull/131/files#diff-7327496955357b9792bab8720dc507d6R222), so you could probably explain it the best way. In hindsight, I agree that it seems dubious and we should reconsider it.

@ronag
Copy link
Contributor Author

ronag commented Oct 16, 2018

Hm, I will have to send a message back in time to myself. I'll add a new PR removing it.

This was referenced Oct 16, 2018
Closed
Merged
@Acconut
Copy link
Member

Acconut commented Oct 20, 2018

We will never know :) Thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Acconut @ronag