Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance metadata in gRPC Hooks #811

Closed
jonaskaltenbachz opened this issue Sep 14, 2022 · 8 comments
Closed

Enhance metadata in gRPC Hooks #811

jonaskaltenbachz opened this issue Sep 14, 2022 · 8 comments
Labels

Comments

@jonaskaltenbachz
Copy link
Contributor

jonaskaltenbachz commented Sep 14, 2022

Hello,

is there a possibility to enhance the metadata object by an additional field in the pre-create gRPC Hook?
Or is there any other possibility to add some metadata automatically?

Many greetings
Jonas

@Acconut
Copy link
Member

Acconut commented Sep 14, 2022

No, there currently exists no method for modifying the metadata of an upload. Neither using gRPC nor any other hook method. However, I am thinking about allowing this for the pre-create hook in the future.

@jonaskaltenbachz
Copy link
Contributor Author

All right, I understand.
I have created a pull request that enables the described functionality: #814

@jonaskaltenbachz
Copy link
Contributor Author

Hello,
I just wanted to ask if there is an update on this topic.

Many greetings,
Jonas

@Acconut
Copy link
Member

Acconut commented Oct 18, 2022

Hi Jonas, please see #814 for my response :)

@jonaskaltenbachz
Copy link
Contributor Author

Hello,
I just wanted to ask if there is an update on this topic.

Many greetings,
Jonas

@Acconut
Copy link
Member

Acconut commented Jan 18, 2023

Unfortunately, there has been no work performed on this in the recent months.

@jonaskaltenbachz
Copy link
Contributor Author

Thank you for your answer @Acconut
I prepared the pull request in #814. Do you saw this too? From my point of view it should be ready to merge.

Best regards,
Jonas

@Acconut
Copy link
Member

Acconut commented Jun 9, 2023

I am closing this issue since we now have a PR that tracks progress on this: #962.

@Acconut Acconut closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants