Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for improving the dialog component #2062

Closed
cefiro opened this issue Dec 28, 2021 · 6 comments
Closed

Suggestion for improving the dialog component #2062

cefiro opened this issue Dec 28, 2021 · 6 comments
Labels
feature request New feature or request

Comments

@cefiro
Copy link

cefiro commented Dec 28, 2021

This function solves the problem (这个功能解决的问题)

Usability of the dialog box

Expected API (期望的 API)

  1. [Very necessary] Blocking the "Negative button" when the loading property = true or give access to button properties;

  2. [Very necessary] Adding a dialog closing event to the "ESC" key;

  3. Make "useDialog" promisable for comfortable work with asynchronous functions.

Example:

async test() {
    await useDialog().success(...);
    // resolve: click on a positive button
}
@github-actions github-actions bot added the feature request New feature or request label Dec 28, 2021
@07akioni
Copy link
Collaborator

I'll think of it.

@07akioni
Copy link
Collaborator

07akioni commented Dec 28, 2021

  1. consideration needed
  2. should do
  3. consideration needed

@cefiro
Copy link
Author

cefiro commented Dec 28, 2021

Thanks :)

@Talljack
Copy link
Contributor

  1. consideration needed
  2. should do
  3. consideration needed

2是不是已经做了?

@07akioni
Copy link
Collaborator

  1. consideration needed
  2. should do
  3. consideration needed

2是不是已经做了?

We haven't finished 2. If esc is pressed, no callback will be fired. You may mean close (clicked) event.

@jahnli
Copy link
Collaborator

jahnli commented Mar 12, 2024

This issue does not have any recent activity. If you are still experiencing similar problems, open a new error, including a minimal copy of the problem

@jahnli jahnli closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants