Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRadio label #2707

Closed
EgorPopovPP opened this issue Mar 30, 2022 · 5 comments · Fixed by #2728
Closed

NRadio label #2707

EgorPopovPP opened this issue Mar 30, 2022 · 5 comments · Fixed by #2728
Labels
feature request New feature or request pr welcome

Comments

@EgorPopovPP
Copy link
Contributor

EgorPopovPP commented Mar 30, 2022 •
edited
Loading

This function solves the problem (这个功能解决的问题)

Now, we have NRadio API, when we must place label string inside default slot

<n-radio>My Label</n-radio>

Expected API (期望的 API)

To improve DX, we must have prop like label in NCheckbox component
Than we get

<n-radio label="My Label" />
@github-actions github-actions bot added the feature request New feature or request label Mar 30, 2022
@EgorPopovPP
Copy link
Contributor Author

I can take this issue for my first PR 😉

@EgorPopovPP
Copy link
Contributor Author

@amadeus711 @07akioni can i?)

@Talljack
Copy link
Contributor

Talljack commented Mar 30, 2022 •
edited
Loading

@amadeus711 @07akioni can i?)

you can do it

@EgorPopovPP
Copy link
Contributor Author

@Talljack I will take it in few days

@Talljack
Copy link
Contributor

@Talljack I will take it in few days

okay, great

@EgorPopovPP EgorPopovPP mentioned this issue Apr 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request pr welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(radio): add radio label EgorPopovPP/naive-ui
2 participants
@Talljack @EgorPopovPP