Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs' bar not hidden on manual update #5100

Closed
vaibhav11s opened this issue Jul 25, 2023 · 2 comments · Fixed by #5098
Closed

Tabs' bar not hidden on manual update #5100

vaibhav11s opened this issue Jul 25, 2023 · 2 comments · Fixed by #5098
Labels
bug Something isn't working

Comments

@vaibhav11s
Copy link
Contributor

TuSimple/naive-ui version (版本)

2.34.4

Vue version (Vue 版本)

3.3.4

Browser and its version (浏览器及其版本)

All

System and its version (系统及其版本)

All

Node version (Node 版本)

Reappearance link (重现链接)

https://codesandbox.io/s/busy-hooks-j7fxl2

Reappearance steps (重现步骤)

click on any tabs from the options. if we click on the tab from the second group, the previous tab get inactive, but the tab-bar stays in place.

Expected results (期望的结果)

The inactivated tab's tab-bar should be hidden

Actual results (实际的结果)

inactivated tab's tab-bar stays visible

Remarks (补充说明)

I was trying to make the nested routes layout with tabs. when we selected the different route group item, previous group tab-bar was still visible.

@github-actions github-actions bot added the untriaged need to sort label Jul 25, 2023
@vaibhav11s
Copy link
Contributor Author

Raised PR #5098 to solve this issue.

@XieZongChen XieZongChen linked a pull request Jul 26, 2023 that will close this issue
@07akioni 07akioni added bug Something isn't working and removed untriaged need to sort labels Dec 20, 2023
@07akioni
Copy link
Collaborator

fix in next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants