Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser-based login does not work #4592

Closed
puckipedia opened this issue Jul 30, 2024 · 12 comments · Fixed by #4704
Closed

Browser-based login does not work #4592

puckipedia opened this issue Jul 30, 2024 · 12 comments · Fixed by #4704
Labels

Comments

@puckipedia
Copy link

Detailed description

When I return from browser-based OAuth, the domain, clientId, and clientSecret variables are all blank (never persisted to storage), and authentication fails with "An unidentified authorization error occurred.".

Steps to reproduce the problem

No response

Debug information

Tusky Test 26.0-0f3dd64c
Google Pixel 6
Android version: 14
SDK version: 34

The account is on my own server software, which implements the right API contract for returning an OAuth code to Tusky (verified with a debugger).

@puckipedia puckipedia added the bug label Jul 30, 2024
@Tak
Copy link
Collaborator

Tak commented Aug 5, 2024

Hi, have you also tried the "Login with Browser" item from the three-dots menu on the login screen?

@puckipedia
Copy link
Author

Yes, that's what I meant with "Browser-based OAuth".

@Tak
Copy link
Collaborator

Tak commented Aug 5, 2024

Ok, but then it does work with the default embedded webview?

@puckipedia
Copy link
Author

No; using the embedded webview on my server shows the following (which is correct, it requires Basic auth and, sometimes, webauthn):
Screenshot_20240805-150941

And using the browser lets me log in, but returns "An unidentified authorisation error has occurred", which, after running Tusky in a debugger, is caused by the issue I specified in the issue.

@puckipedia
Copy link
Author

puckipedia commented Aug 5, 2024

In fact, testing with the most recent version of Tusky available in F-Droid (26.0), I cannot even log in to mastodon.social using the browser based flow, as the issue I mentioned isn't caused by any API call.

@charlag
Copy link
Collaborator

charlag commented Aug 5, 2024

just tried m.s. with tusky 26 from f-droid and it works. probably the only difference between your setup and mine is WebView

@charlag
Copy link
Collaborator

charlag commented Aug 5, 2024

oh sorry you meant browser-flow, missed that

@charlag
Copy link
Collaborator

charlag commented Aug 5, 2024

can confirm, browser-based login didn't work for me with m.s.

Screenshot_20240805-155121

@tiptoptom
Copy link

Could this be the problem?
zacharee/MastodonRedirect#25

@edwardp3
Copy link

Having same issue with browser-based login. Same error as per @charlag above. Android 10, version 26.0 of Tusky app.

@ma3s7r0
Copy link

ma3s7r0 commented Aug 26, 2024

Same problem here, pixel 8, latest os, tusky 26.1, can’t login to chaos.social.

@jamagin
Copy link

jamagin commented Dec 3, 2024

Any chance this is going to be released in the Google play store soon? At least in the beta channel?

I can't use Tusky until that happens

(Edit: OMG thank you!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants