Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preshared password field in Contact editor is not a password field #4617

Closed
6 tasks done
ganthern opened this issue Sep 28, 2022 · 0 comments · Fixed by #6931
Closed
6 tasks done

Preshared password field in Contact editor is not a password field #4617

ganthern opened this issue Sep 28, 2022 · 0 comments · Fixed by #6931
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Milestone
230.240603.0

Comments

@ganthern
Copy link
Contributor

ganthern commented Sep 28, 2022 •
edited by paw-hub
Loading

we should change it to a password field with reveal button.

Test notes:

  • Pressing the reveal button while the text is obscured reveals the inputted password.
  • Pressing the reveal button while the text is visible hides the inputted password.
  • PresharedPasswordField appears as a password field with a reveal button.
  • The recover login dialog still works.
  • Entering a password when sending an encrypted mail to an external address still works.
  • Password fields in the sign up wizard work.
@ganthern ganthern added bug broken functionality, usability problems, unexpected errors ui visual glitches, missing buttons, wrong text... labels Sep 28, 2022
@rezbyte rezbyte self-assigned this Apr 26, 2024
@rezbyte rezbyte mentioned this issue May 13, 2024
Merged
@wrdhub wrdhub added the state:done meets our definition of done label May 17, 2024
@kibibytium kibibytium added this to the Notifications milestone May 21, 2024
@paw-hub paw-hub self-assigned this May 27, 2024
@paw-hub paw-hub added the state:tested We tested it and are about to release it label May 27, 2024
@paw-hub paw-hub removed their assignment May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Projects
None yet
Milestone
230.240603.0
Development

Successfully merging a pull request may close this issue.

Unify the password fields into a single component tutao/tutanota
5 participants
@ganthern @rezbyte @kibibytium @paw-hub @wrdhub