Missing whitelabel themes in wizard

[murilopereirame]

On Android one of the whitelabel themes is missing and to show the first one, I had to trigger the wizard several times through the about dialog.

Steps to reproduce:
On Android:

1. Add an account with whitelabel theme
2. Trigger the wizard
3. On theme step, see that there's no whitelabel theme

Originally posted by @murilopereirame in #6770 (comment)

Test Notes

• Whitelabel themes are displayed during the onboard wizard

[rezbyte]

I cannot seem to reproduce this. In the second screenshot, it seems that the custom colors are disabled.

[charlag]

Also on the first screenshot there clearly is a whitelabel theme, I will try to repro it as well but if not then I'd say it's okay

[murilopereirame]

I cannot seem to reproduce this. In the second screenshot, it seems that the custom colors are disabled.

Good catch, but the color was enabled on the web. Could be just a server delay?

Also on the first screenshot there clearly is a whitelabel theme, I will try to repro it as well but if not then I'd say it's okay

Yes, but should have two of them, one for mup4test and one for vaf

[rezbyte]

Good catch, but the color was enabled on the web. Could be just a server delay?

So if I am correct, you had the both the web and Android clients open at the same time. The web client with the custom colors and the Android without. Is that right?

If that is the case, I do not think it is related to the onboarding wizard. The Android client was respecting the settings it had. This might be an issue about syncing user settings.

Yes, but should have two of them, one for mup4test and one for vaf

If the custom colors were disabled on the Android client, the vaf theme would not appear.

[murilopereirame]

So if I am correct, you had the both the web and Android clients open at the same time. The web client with the custom colors and the Android without. Is that right?

If that is the case, I do not think it is related to the onboarding wizard. The Android client was respecting the settings it had. This might be an issue about syncing user settings.

No, I setup the whitelabel on the web, put a nice color on it and after that I added the account to the android device and the theme wasn't shown up.

If the custom colors were disabled on the Android client, the vaf theme would not appear.

Yes, probably is related to the last question. Also the vaf theme took a while to appears into the wizard, I had to trigger the wizard 2/3 times

To be honest, maybe isn't a thing with the wizard itself, but with the load process of custom themes.

[charlag]

I mentioned it but maybe only in person but the wizard page grabs only what is already loaded:
https://github.com/tutao/tutanota/pull/6785/files#diff-9bb05348e2e34585caf2fecc84648f110a3d340be0bc1f5b26c7cbe2e9a167dfR14

so it's probably a timing issue, whether PostLoginActions will add a theme first or not. We should probably make sure we do run storeNewCustomThemes() (or some alternative) when showing the wizard