Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels might be enabled before they should be #8029

Closed
5 tasks done
charlag opened this issue Nov 26, 2024 · 0 comments · Fixed by #8032
Closed
5 tasks done

Labels might be enabled before they should be #8029

charlag opened this issue Nov 26, 2024 · 0 comments · Fixed by #8032
Assignees
@paw-hub @hrb-hub
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues ios issues that concern the ios client but not all clients state:tested We tested it and are about to release it
Milestone
252.241126.0

Comments

@charlag
Copy link
Contributor

charlag commented Nov 26, 2024 •
edited by hrb-hub
Loading

FeatureType.Label is the same value as FeatureType.Blobs. If Customer was not updated for a while the client might be confused about current value.

Test notes

Test locally:

  • Modify DeleteUnusedFeaturesBatchJob to also remove Labels feature
  • Add Labels feature to a customer
  • Log in on a platform with offline, log out
  • Run cleanup-unused-features job against that customer
  • Log in again, see that labels are correctly disabled again.
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Nov 26, 2024
@charlag charlag added desktop Desktop client related issues android issues that concern the android client but not all clients ios issues that concern the ios client but not all clients labels Nov 26, 2024
@charlag charlag mentioned this issue Nov 26, 2024
Merged
@charlag charlag added this to the 252.241126.0 milestone Nov 26, 2024
@hrb-hub hrb-hub added the state:tested We tested it and are about to release it label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paw-hub paw-hub

@hrb-hub hrb-hub

Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors desktop Desktop client related issues ios issues that concern the ios client but not all clients state:tested We tested it and are about to release it
Projects
None yet
Milestone
252.241126.0
Development

Successfully merging a pull request may close this issue.

Fix outdated customer customizations tutao/tutanota
3 participants
@charlag @paw-hub @hrb-hub