Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de.tutao.tutanota very close to reproducible builds #8154

Open
2 tasks done
eighthave opened this issue Dec 17, 2024 · 1 comment
Open
2 tasks done

de.tutao.tutanota very close to reproducible builds #8154

eighthave opened this issue Dec 17, 2024 · 1 comment
Labels
bug broken functionality, usability problems, unexpected errors

Comments

@eighthave
Copy link

  • This is not a feature request (existing functionality does not work, not missing functionality).
    I will request features on forum or via support.
  • I've searched and did not find a similar issue.

Bug in mobile app

Describe the bug

There looks to be unsorted generated output in assets/tutanota/sw.js which is the only thing breaking reproducible builds for the APKs. It looks like these items in particular do not have a fixed order:

  • invoice-DyIaiday.js.map
  • native-common-DuMw-wf5.js.map
  • translation-en-D8ZBhL8N.js

To Reproduce

  1. Run the build twice
  2. Use diffoscope to compare the resulting APKs
  3. See the diff: https://verification.f-droid.org/de.tutao.tutanota_396418.apk.diffoscope.html

Expected behavior

Sorted output so the build is reproducible each time it is run. It should be a simple fix: just sort the file names before before adding them to assets/tutanota/sw.js.

Screenshots

Screenshot from 2024-12-17 17-17-15

@eighthave eighthave added the bug broken functionality, usability problems, unexpected errors label Dec 17, 2024
@charlag
Copy link
Contributor

charlag commented Dec 17, 2024

sw.js should not be included in Android app anyway 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors
Projects
None yet
Development

No branches or pull requests

2 participants