Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation keys still in the code deleted #8445

Open
1 task
YohYamasaki opened this issue Jan 31, 2025 · 1 comment
Open
1 task

Translation keys still in the code deleted #8445

YohYamasaki opened this issue Jan 31, 2025 · 1 comment
Labels
bug broken functionality, usability problems, unexpected errors

Comments

@YohYamasaki
Copy link
Contributor

The following translation keys have been removed from Phrase but are still in the code, so we need to manually add the keys to the en.ts, de.ts and die_sie.ts files to pass the test.
These keys are in the code, but as the local admin group is deprecated, their use should be removed from the code.

"localAdminGroup_label": "Local admin group",
"assignAdminRightsToLocallyAdministratedUserError_msg": "You can't assign global admin rights to a locally administrated user.",
"localAdminGroups_label": "Local admin groups"

Tasks

  • Remove all the places which uses the above keys in the code.
@YohYamasaki YohYamasaki added the bug broken functionality, usability problems, unexpected errors label Jan 31, 2025
@charlag
Copy link
Contributor

charlag commented Jan 31, 2025

see #8137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants