Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button still enabled for toasts with dismissable false when closeButton is true #11

Closed
1 of 2 tasks
charlieandroid55 opened this issue Apr 9, 2024 · 1 comment · Fixed by #12
Closed
1 of 2 tasks
Labels
bug Something isn't working released

Comments

@charlieandroid55
Copy link

Please provide the environment you discovered this bug in.

<ngx-sonner-toaster closeButton="true"/>
 toast.error('Error toast', {dismissable: false});

Description

When the closeButton option is set to true, all of my toasts have a close button. However, if I launch a toast with dismissable: false, the close button is still enabled and functional. Is this behavior intentional? How can I disable the closing of an individual toast if I have closeButton: true? It should at least work like the behavior of toast.loading()."

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@charlieandroid55 charlieandroid55 added the bug Something isn't working label Apr 9, 2024
@tutkli
Copy link
Owner

tutkli commented Apr 11, 2024

🎉 This issue has been resolved in version 0.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants