Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy_grants config for Snowflake #283

Closed
thutuva opened this issue Nov 14, 2023 · 2 comments
Closed

Add copy_grants config for Snowflake #283

thutuva opened this issue Nov 14, 2023 · 2 comments

Comments

@thutuva
Copy link
Member

thutuva commented Nov 14, 2023

Summary:
Tables and views that have been replicated for a Snowflake share will drop from the share when the table/view is refreshed in dbt. A copy_grants config needs to be added to prevent this from happening. If this config is added to the dbt_project.yml then all models, including in packages, will be given the correct permissions to they don't drop from the share.

Point to discuss with the team:
Should we add +copy_grants: true to the Tuva Project?

  • Pro - tables/views will not get dropped if an open-source user needs to replicate their tables for a Snowflake share.
  • Con - it's redundant because you will have to add this config to your dbt_project.yml for your other (non package) models

Current behavior:
Re-running a dbt project will refresh the data and update the drop tables and views that have been refreshed from a replicated Snowflake share.
Expected behavior:
Re-running a dbt project will refresh the data and update the tables and views that have been replicated for a Snowflake share.

@aneiderhiser
Copy link
Contributor

I don't think we need to build this sort of functionality into the Tuva Project. This is Snowflake data eng functionality, not healthcare analytics. When we're implementing TTP on internal datasets or for customers we'll have a separate dbt project (that imports TTP) where we can add this functionality.

@thutuva
Copy link
Member Author

thutuva commented Dec 15, 2023

I will close this out then.

@thutuva thutuva closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants