Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewbox not working #12

Closed
raphink opened this issue Jun 7, 2012 · 3 comments
Closed

Viewbox not working #12

raphink opened this issue Jun 7, 2012 · 3 comments

Comments

@raphink
Copy link

raphink commented Jun 7, 2012

As I told you on IRC, the viewbox parameter doesn't seem to be honored:

http://nominatim.openstreetmap.org/search.php?q=royan&viewbox=51.94,36.59,51.99,36.56

returns Royan, France by default, even though this viewbox is precisely centered on Royan, Iran.

@raphink
Copy link
Author

raphink commented Jul 26, 2012

This issue is still present. Another example with Lyon:

http://nominatim.openstreetmap.org/search.php?q=lyon&viewbox=3.77%2C46.13%2C5.74%2C45.26

@lonvia
Copy link
Member

lonvia commented Apr 18, 2013

Search was taking the viewbox into account but the final ranking of the results was not. I've now built in some additional adaption of the importance ranking according to viewbox, at the moment only for testing on osm.org. It might return unexpected results for well-known cities, i.e. when searching for Lyon, I'd always expect the French city to turn up not some barely inhabited American county, even if the map view is pointing to the US. Let's see if there are any complaints.

@lonvia
Copy link
Member

lonvia commented Apr 30, 2013

There were no complaints so far. If there are no other objections I'll merge the relevant changes into the main branch in a short while.

@lonvia lonvia closed this as completed in 21adb37 Apr 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants