Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "strip for ie7" code from JavaScript #10441

Closed
cvrebert opened this issue Sep 4, 2013 · 2 comments
Closed

Remove "strip for ie7" code from JavaScript #10441

cvrebert opened this issue Sep 4, 2013 · 2 comments

Comments

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 4, 2013

There are several instances of this code snippet (or similar) in Bootstrap's JavaScript:

selector = selector && selector.replace(/.*(?=#[^\s]*$)/, '') // strip for ie7

Since Bootstrap v3 no longer supports IE7, we should remove this code to simplify things and improve performance.

@cnanney
Copy link

cnanney commented Dec 3, 2013

From the documentation:

Unofficially, Bootstrap should look and behave well enough in Chromium and Chrome for Linux, Firefox for Linux, and Internet Explorer 7, though they are not officially supported.

Is it worth it to kill these components in IE7 for very minimal gains? Removing cumbersome IE7 CSS hacks is one thing, but to arbitrarily break components is another.

@fat
Copy link
Member

fat commented Dec 24, 2013

yeah we aren't going to get any tangible perf gain from removing 1 tiny regexp… especially since that regexp is tied directly to events

I think we should leave it for now… doesn't hurt anything

@fat fat closed this as completed Dec 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants