Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal using remote URL does not load #14330

Closed
seanmon opened this issue Aug 5, 2014 · 3 comments
Closed

Modal using remote URL does not load #14330

seanmon opened this issue Aug 5, 2014 · 3 comments

Comments

@seanmon
Copy link

seanmon commented Aug 5, 2014

Recently upgraded application to 3.2.0 and remote modals don't seem to work anymore.

When I click on the link the screen dims but the modal content does not load. No attempt to fetch the URL is seen on the server side.

Reproduced error on JS Bin... Downgrading to older version (3.0.0) does work, see bin...

http://jsbin.com/camizo/20/edit?html

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2014

If you're upgrading directly from 3.0.0 to 3.2.0, you'll need to account for the incompatible remote modal change made in 3.1.0+.
See the "Remote modal content" section on https://github.com/twbs/bootstrap/releases/tag/v3.1.0

[...]
If you currently use the modal's remote option, be aware this release may break your modals. Yes, this is a breaking change, but it's first and foremost a bug fix one that corrects a rather longstanding and overlooked error. Our apologies for any headaches it may cause, but it's been missed in the last few patch releases.

See the #11933 pull request for details on the code changes.

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2014

Your div.modal#remote needs to contain .modal-dialog and .modal-content <div>s in the non-remote markup.

It's also worth noting that the remote option is being deprecated as of v3.2.1.

@cvrebert cvrebert closed this as completed Aug 5, 2014
@seanmon
Copy link
Author

seanmon commented Aug 5, 2014

Sorry about that... didn't look far enough back..

Moved dialog and content up a level and everything is working as it should...

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants