Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid gutter issue with uneven pixel values #16281

Closed
7R5N opened this issue Apr 13, 2015 · 1 comment · Fixed by #16351
Closed

Grid gutter issue with uneven pixel values #16281

7R5N opened this issue Apr 13, 2015 · 1 comment · Fixed by #16351
Labels
Milestone

Comments

@7R5N
Copy link

7R5N commented Apr 13, 2015

I have a layout with a 1px grid gutter; the columns are colored boxes.

Bootstrap’s grid translates this in -0.5px margins along with 0.5px paddings. That seems to work, actually (and I have tested it in some browsers), because the bowsers seem to generally decide if they tilt the columns to the left or to the right, to finally feature one full pixel gap.

But this feels overall accidentally, and I’m worried that that this might break on day, at least when it comes to sub pixel rendering … 

So I’m asking myself if it wouldn’t be a good idea to enhance the grid mixin with a logic for uneven values, that produces regardeless just full pixel values; in my case 1px left, 0px right, for example.

Alternatively maybe optional variables for left-/right-gutter-part would be fine.

Thanks a lot,
7R5N

@cvrebert cvrebert added the css label Apr 13, 2015
@mdo
Copy link
Member

mdo commented Apr 13, 2015

We should round up to the nearest pixel values, though come v4 it'd be nice to not dividing values for their true purposes. The latter there will be a fix I can make for our v4, but the former could be done in v3 if someone wanted to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants