Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height of plain <input type="week"> doesn't match height of other temporal <input>s in Chrome #16346

Closed
cvrebert opened this issue Apr 23, 2015 · 5 comments · Fixed by #16472
Closed
Labels

Comments

@cvrebert
Copy link
Collaborator

As a side-effect of

@media screen and (-webkit-min-device-pixel-ratio: 0) {
, the height of a plain <input type="week"> without any Bootstrap classes doesn't match the height of other plain temporal <input>s.
Tested on OS X Chrome using http://jsfiddle.net/5Lh045wd/1/

@cvrebert cvrebert added the css label Apr 23, 2015
@cvrebert
Copy link
Collaborator Author

I'm thinking we should add .form-control to these selectors?
We never make plain temporal <input>s be display: block in the first place.

@cvrebert
Copy link
Collaborator Author

CC: @mdo

@mdo
Copy link
Member

mdo commented Apr 27, 2015

Sounds fine by me.

@mdo
Copy link
Member

mdo commented Apr 27, 2015

In fact I've got that temporal stuff commented out in v4 so far. Haven't tested it much yet though, but I wasn't sure if we needed it if we're going class-only for more of our styles.

@mdo
Copy link
Member

mdo commented May 14, 2015

We do need it in v4 still I think. Fuck that bug, ugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants